Merge original typing from types-redis, adapt it for valkey. #134
Conversation
|
@amirreza8002 Let's discuss about the state of the PR here. So my approach was to use the test suite as a baseline to have working type hints, so I gradually enable mypy on the files in the test suite: https://github.com/Rafiot/valkey-py/blob/types-signed-off-take2/.mypy.ini And adapt either the test suite, or the typing, depending on the issues reported by mypy. One day, we should try to get rid of the |
|
hi and what parts do you need help with? or what parts you aren't gonna do for now? so we don't end up working on the same thing |
|
I'm working on something else right now, so I don't have anything going that is not in this PR. Feel free to work on anything you want. The next steps are to run mypy on more of the test files, so feel free to pick anything you want. If you have something ongoing and you don't push it same day, please add a comment here so we don't duplicate the work. Thanks! The important thing to keep in mind is that you always signoff the commits, it's required to merge it, and it is a mess to fix later on (as I realized today). |
Rafiot
force-pushed
the
types-signed-off-take2
branch
2 times, most recently
from
f271a43 to
e9272c7
Compare
Signed-off-by: Raphaël Vinot <[email protected]>
Rafiot
force-pushed
the
types-signed-off-take2
branch
from
e9272c7 to
b952e8d
Compare
Replacement PR for #93, this time with signoff (sorry for the noise, I had a fight with git and it seems to be the easiest way out).
Still not ready for merging.